Linux Format forums

Re: Shell Loops me mad

Gordon — Thu Jul 28, 2005 4:57 pm

Author: Gordon

Posted: Thu Jul 28, 2005 4:57 pm

No probs. You could try looking at the "Advanced Bash Scripting Guide" which is on the LXF70 DVD.

Gordon

Re: Shell Loops me mad

RD — Thu Jul 28, 2005 4:53 pm

Author: RD

Posted: Thu Jul 28, 2005 4:53 pm

Hi,

Im embarrested and angriy simple because i was given a half finished code that i thought was genuine to later find out that it had/has been cp by Wrox, i feel cheated out of trying to learn a new skill, in future rather than jumping in head first i shall do some home work first.

BTW thanks

Re: Shell Loops me mad

Gordon — Thu Jul 28, 2005 4:19 pm

Author: Gordon

Posted: Thu Jul 28, 2005 4:19 pm

Hi RD, sorry to have caused you embarresment and anger. But I had also tried the code a few years ago myself from the Wrox book and it didn't work for me then either. Although the code from the book is copyright Wrox press, it is still under the GNU GPL licence, so you can still use it or modify it as long as you make such modifications available to others and acknowledge Wrox as the copyright holders.

Don't let this put you off learning bash scripting though.

With all due respect to Wrox though, "Beginning Linux Programming" may be worth a read. Would Linux Format consider doing a review of the latest edition?

Nigel, The code from the book does have some of the same typoes, such as the "cdttitle" variable.

I hope nobody feels too badly about this.

Regards to all concerned. Gordon

Re: Shell Loops me mad

Nigel — Thu Jul 28, 2005 12:57 am

Author: Nigel

Posted: Thu Jul 28, 2005 12:57 am

RD - well, at least you have learned something about shell scripts. And I have to admit, so have I - I hadn't used case statements in bash scripts before (although I use them all the time in C). So it hasn't been a complete waste of time.
You may find after a bit of research that you are free to use the script itself, but changing the copyright assignment is a definite no-no.

And this is a good example of why SCO won't find any dodgy code in Linux - with development done so publicly, anything that isn't kosher gets outed very quickly

Re: Shell Loops me mad

RD — Thu Jul 28, 2005 12:24 am

Author: RD

Posted: Thu Jul 28, 2005 12:24 am

Gordon, after a quick google it would seem you was write and i had been given half finished stole code to finish as a result i will speak to the person who gave me the half finished code and to wrox about this matter, as a result i have had no choice but to edit and remove the copy right code from the forums and shall not be acceppting any more code from the person who was supose to "help me understand the shell coding" , this is an out right embaresment , Nigel it would seem that i have wasted your time and my own and was fooled into thinking that this was genuine.

NOT A HAPPY BUNNY

Re: Shell Loops me mad

Nigel — Wed Jul 27, 2005 10:58 pm

Author: Nigel

Posted: Wed Jul 27, 2005 10:58 pm

Does the code in the book have all the typos in it as well

Re: Shell Loops me mad

Gordon — Wed Jul 27, 2005 10:09 pm

Author: Gordon

Posted: Wed Jul 27, 2005 10:09 pm

I thought I recognized this code. It seems to be the code from the book "Beginning Linux Programming", Wrox Press, ISBN 1-874416-68-0, chapter 2, code starts on page 72 inmy copy and is copyrighted to Wrox Press 1996. Did K Windle write the original for Wrox?

Re: Shell Loops me mad

Nigel — Wed Jul 27, 2005 9:43 pm

Author: Nigel

Posted: Wed Jul 27, 2005 9:43 pm

Hi RD,

the basic problem was that you haven't terminated the section above properly - check you have two semicolons at the end of line 324.

I don't think the editor you use will make any difference (I use vi, mostly because I'm too lazy to learn anything else )

Re: Shell Loops me mad

RD — Wed Jul 27, 2005 7:28 pm

Author: RD

Posted: Wed Jul 27, 2005 7:28 pm

Here is more info on the error im getting

Mini CD manager
cd_manager.sh: line 325: syntax error near unexpected token `)'
cd_manager.sh: line 325: ` q | Q) quit=y;;'

i've tryed in vi emacs and kdevelop and still getting the same error

Re: Shell Loops me mad

RD — Wed Jul 27, 2005 7:02 pm

Author: RD

Posted: Wed Jul 27, 2005 7:02 pm

Hi Nigel

First thanks for the help

Now i've been getting the same problem as yourself ie won't let me quit how ever the original was wirtten with q | Q) quit=y;; and every time i tryed to run the script it keept giving errors

also as it was written using kdevelop i felt it best to just leave the default settings ie #!/bin/sh or bash which ever you want i do know that this is normally located at the top of the shell script, any way what do you suggest as to the not quitting problem ?

RD

Re: Shell Loops me mad

Nigel — Mon Jul 25, 2005 11:06 pm

Author: Nigel

Posted: Mon Jul 25, 2005 11:06 pm

Well, it doesn't loop for me - as posted, the script seems to work fine in that area... but you have fixed the typo from your earlier post

The only problem I see with it now is that it won't let you quit from the main menu...
you need to change the section

Code:

b)
echo
more $title_file
echo
get_return
q | Q quit=y;;
*) echo "Sorry, choice not recognized";;

near the end to read

Code:

b)
echo
more $title_file
echo
get_return;;
q | Q) quit=y;;
*) echo "Sorry, choice not recognized";;

One tip - the line

Code:

#!/bin/bash

usually goes right at the top of the file, before any comments. Doesn't matter for users whose default shell is bash, but as written it throws up a heap of errors if run under csh. Moving the /bin/bash line to the top sorts that out.

Re: Shell Loops me mad

RD — Mon Jul 25, 2005 6:47 pm

Author: RD

Posted: Mon Jul 25, 2005 6:47 pm

Sorry was in a bit of a rush so heres the script please run it then you will see the problems i seem to be having

Code:

# Tidy up and leave the application

rm -f $temp_file
echo "Thank you for using this application :-)"
exit 0

RE: Re: RE: Re: Shell Loops me mad

RD — Mon Jul 25, 2005 6:29 pm

Author: RD

Posted: Mon Jul 25, 2005 6:29 pm

near the start of the script

Re: RE: Re: Shell Loops me mad

Nigel — Mon Jul 25, 2005 5:31 pm

Author: Nigel

Posted: Mon Jul 25, 2005 5:31 pm

RD wrote:

That was not a typo here is how it was suppose to be

sorry - you are setting cdtitle (one "t") to the value of tmp without the commas, then testing cdttitle (two "t"s) against the value of tmp...
either one of these has a typo in it, or you're not showing us some code which is vital to sorting this problem (ie where you are setting cdttitle (with two "t"s)

RE: Re: Shell Loops me mad

RD — Mon Jul 25, 2005 5:21 pm

Author: RD

Posted: Mon Jul 25, 2005 5:21 pm

That was not a typo here is how it was suppose to be

while [ "$cdttitle" != "q" ]
do
echo -e "Track $cdtrack, track title? \c"
read tmp
cdtitle=${tmp%%,*}
if [ "$tmp" != "$cdttitle" ] ; then # Keeps looping here ???
echo "Sorry, no commas allowed"
continue
fi

if [ -n "$cdttitle" ] ; then
if [ "$cdttitle" != "q" ] ; then

I had another look after posting it did not work then found out i missed a t in while [ "$cdttitle" != "q" ] also
cdtrack=$((cdtrack+1))

worked just fine i am having another problem which when i get back home i will post at where i think the problem is

Thanks guys for the help