Linux Format forums

[RD]

Hi

Im trying to write my first shell script and well its not going too well right now as it keeps looping in one area and im not too sure as why im kinda hoping you guys could help out and tell me what im doing wrong

here is the section of code it loops on

add_record_tracks() {
echo "Enter track information for this CD"
echo "When no more tracks enter q"
cdtrack=1
cdtitle=""
while [ "$cdtitle" != "q" ]
do
echo -e "Track $cdtrack, track title? \c"
read tmp
cdtitle=${tmp%%,*}
if [ "$tmp" != "$cdttitle" ] ; then # Keeps looping here ???
echo "Sorry, no commas allowed"
continue
fi

if [ -n "$cdttitle" ] ; then
if [ "$cdttitle" != "q" ] ; then
insert_track $cdcatnum,$cdtrack,$cdtitle
fi
else
cdtrack=$(cdtrack-1)
fi
cdtrack=$(cdtrack+1)
done

It keeps repeating that no commas are allowed even when i don't put any in
i would be grate full of any help you can provide as to why as im at a loss right now

[RD]

sorry guys did not relize id already posted twice
_________________
[url=irc://irc.ixl2.org/ixl2]irc.ixl2.org[/url]

[Nigel]

You have a typo in your if test - you are comparing cdttitle to tmp when I think you want to be comparing cdtitle with one less "t"

You have the same typo further down as well.

And your increment/decrement statements for cdtrack won't work - they should be of the form

cdtrack=$(($cdtrack+1))
_________________
Hope this helps,

Nigel.

[Nobber]

Atrithmetic in bash scripts can be confusing, because there are so many ways to do it. For example, to add 1 to cdtrack, any of these would work:

((cdtrack++))

cdtrack=$(($cdtrack+1))

cdtrack=$((cdtrack+1))

let cdtrack=cdtrack+1

And there are probably several other ways. I can never make up my mind which form to use.
_________________
800 LINES ERIC - GET BACK TO PYSKOOL

[RD]

Hi giuys thanks for the repliys but it did not work its still looping the sorry commas not allowed no matter what i put

[Nobber]

Odd. I copied and pasted your script, corrected the variable and arithmetic typos already pointed out, and it seems to work OK.

Post your script again.
_________________
800 LINES ERIC - GET BACK TO PYSKOOL

[Nigel]

I also copied & ran the script to find the original problem (typos like that are very easy to miss !)

Make sure that you changed

[RD]

That was not a typo here is how it was suppose to be

while [ "$cdttitle" != "q" ]
do
echo -e "Track $cdtrack, track title? \c"
read tmp
cdtitle=${tmp%%,*}
if [ "$tmp" != "$cdttitle" ] ; then # Keeps looping here ???
echo "Sorry, no commas allowed"
continue
fi

if [ -n "$cdttitle" ] ; then
if [ "$cdttitle" != "q" ] ; then


I had another look after posting it did not work then found out i missed a t in while [ "$cdttitle" != "q" ] also
cdtrack=$((cdtrack+1))

worked just fine i am having another problem which when i get back home i will post at where i think the problem is

Thanks guys for the help
_________________
[url=irc://irc.ixl2.org/ixl2]irc.ixl2.org[/url]

[Nigel]

[RD]

near the start of the script
_________________
[url=irc://irc.ixl2.org/ixl2]irc.ixl2.org[/url]

[RD]

Sorry was in a bit of a rush so heres the script please run it then you will see the problems i seem to be having

[Nigel]

Well, it doesn't loop for me - as posted, the script seems to work fine in that area... but you have fixed the typo from your earlier post

The only problem I see with it now is that it won't let you quit from the main menu...
you need to change the section

[RD]

Hi Nigel

First thanks for the help

Now i've been getting the same problem as yourself ie won't let me quit how ever the original was wirtten with q | Q) quit=y;; and every time i tryed to run the script it keept giving errors

also as it was written using kdevelop i felt it best to just leave the default settings ie #!/bin/sh or bash which ever you want i do know that this is normally located at the top of the shell script, any way what do you suggest as to the not quitting problem ?

RD
_________________
[url=irc://irc.ixl2.org/ixl2]irc.ixl2.org[/url]

[RD]

Here is more info on the error im getting

Mini CD manager
cd_manager.sh: line 325: syntax error near unexpected token `)'
cd_manager.sh: line 325: ` q | Q) quit=y;;'


i've tryed in vi emacs and kdevelop and still getting the same error

[Nigel]

Hi RD,

the basic problem was that you haven't terminated the section above properly - check you have two semicolons at the end of line 324.

I don't think the editor you use will make any difference (I use vi, mostly because I'm too lazy to learn anything else )
_________________
Hope this helps,

Nigel.